Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rageshake post-sourcemaps #11926

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Fix rageshake post-sourcemaps #11926

merged 1 commit into from
Jan 18, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 18, 2020 •
edited
Loading

Error was "s is not a function" because of how require works.

@turt2live turt2live requested a review from a team January 18, 2020 01:28
@turt2live turt2live merged commit 342d717 into develop Jan 18, 2020
@turt2live turt2live deleted the travis/fix-rageshake branch January 18, 2020 01:36
@bwindels
Copy link
Contributor

I've encountered this issue just now, using riot-web version: 342d717-react-a984f9acf3e1-js-dba08d230e42 which seems to include the fix already.

@jryans jryans mentioned this pull request Jan 20, 2020
Closed
@jryans
Copy link
Collaborator

jryans commented Jan 20, 2020

Looks like the BugReportDialog needs similar treatment, working on it in #11938.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turt2live @bwindels @jryans @t3chguy